Skip to content

Conversation

@chiaramapellimt
Copy link
Contributor

@chiaramapellimt chiaramapellimt commented Oct 28, 2025

What

  • Removed validation checks for produced XML.
  • Removed unnecessary code which was duplicated.
  • Update logback to highlight errors in console.

Why

This functionality for validation of the produced XML against schema is now located within in the main code and the XML will not be produced when the a schema issue occurs.

Type of change

Please delete options that are not relevant.

  • Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@chiaramapellimt chiaramapellimt marked this pull request as ready for review October 29, 2025 16:36
@chiaramapellimt chiaramapellimt requested a review from a team as a code owner October 29, 2025 16:36
@MartinWheelerMT MartinWheelerMT changed the title NIAD-3142 Refactored TransformJsonXmlTool NIAD-3142: Refactor TransformJsonXmlTool Oct 30, 2025
@github-actions
Copy link

  • Surviving mutants in this change: 4
  • Killed mutants in this change: 0
class surviving killed
🧟uk.nhs.adaptors.gp2gp.transformjsontoxmltool.TransformJsonToXml 4 0

See https://pitest.org

@sonarqubecloud
Copy link

@MartinWheelerMT MartinWheelerMT enabled auto-merge (squash) October 30, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants